Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

[Request] Change IP whitelist wildcard #1501

Closed
an0n981 opened this issue Mar 4, 2014 · 15 comments
Closed

[Request] Change IP whitelist wildcard #1501

an0n981 opened this issue Mar 4, 2014 · 15 comments

Comments

@an0n981
Copy link
Contributor

an0n981 commented Mar 4, 2014

The whitelist wildcard for IP addresses should be changed from (wildcard).xxx.xxx.xxx to xxx.xxx.xxx.(wildcard) so that a complete sub net can be whitelisted instead of all IP addresses that end the same.
If this is possible without changing the way domain name wildcards work. Here it does make sense to have the wildcard in the front (wildcard.xprivacy.eu)

For this to work XPrivacy would have to be able to differentiate between IPs and domains, which I don't think it currently does

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 4, 2014

Why does GitHub not show the star symbol :(

@M66B M66B closed this as completed in 1726515 Mar 4, 2014
@M66B
Copy link
Owner

M66B commented Mar 4, 2014

Can you please name an application I can test this with.
I tried almost all my applications, but all use domain names.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 4, 2014

Google play store, google account manager, google play services

Regards,

Anonymous

-------- Original Message --------
From: Marcel Bokhorst notifications@github.com
Sent: March 4, 2014 5:15:12 PM CET
To: M66B/XPrivacy XPrivacy@noreply.github.com
Cc: an0n981 an0n981@posteo.de
Subject: Re: [XPrivacy] [Request] Change IP whitelist wildcard (#1501)

Can you please name an application I can test this with.
I tried almost all my applications, but all use domain names.


Reply to this email directly or view it on GitHub:
#1501 (comment)

@M66B
Copy link
Owner

M66B commented Mar 4, 2014

They use domain names in my case.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 4, 2014

If you send me a test version I'll give it a try

@M66B
Copy link
Owner

M66B commented Mar 4, 2014

Sent by e-mail, because Dev-Host is not working currently.

Note that the user defined functions are moved (you might want to test this too).
https://github.com/M66B/XPrivacy/blob/master/CHANGELOG.md

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 4, 2014

It still only offers to wildcard the first segment. User defined functions work

@M66B
Copy link
Owner

M66B commented Mar 4, 2014

Are you sure it is an IP address in the form xxx.xxx.xxx.xxx ?
The IP address matcher does not match IPv6 addresses and anything alphabetical. Some Google's addresses looks like an IP address, but aren't.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 4, 2014

@M66B
Copy link
Owner

M66B commented Mar 4, 2014

The IP address is not recognized because the pattern doesn't recognize port numbers. I will fix that later tonight or tomorrow.

@M66B
Copy link
Owner

M66B commented Mar 4, 2014

I have sent another test version by e-mail.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 4, 2014

Confirmed working

@M66B
Copy link
Owner

M66B commented Mar 4, 2014

Good!
It is a nice addition.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 4, 2014

I just found another app to test with 'chat secure'

@M66B
Copy link
Owner

M66B commented Mar 4, 2014

I have tested the code another way, so I am quite sure it is okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants