Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could Identifier highlight support be added? #20

Open
YaQia opened this issue Feb 4, 2023 · 2 comments
Open

Could Identifier highlight support be added? #20

YaQia opened this issue Feb 4, 2023 · 2 comments

Comments

@YaQia
Copy link

YaQia commented Feb 4, 2023

It seems the highlighting in makefile is not implemented. Here is the picture:
image
image
I'm not familiar with lua. In case of bad implementation (there are too many color symbols), I'll appreciate the contribution from developers.

@YaQia
Copy link
Author

YaQia commented Feb 4, 2023

I found the definition of @symbol, which links to Identifier. I changed the Identifier's color into light_blue, and the color seems to be great to me.

Here is the modification:

--- a/lua/darkplus/theme.lua
+++ b/lua/darkplus/theme.lua
@@ -101,7 +101,7 @@ theme.set_highlights = function()
   hl(0, "Todo", { fg = c.magenta, bg = 'NONE', bold = true, })
   hl(0, "Error", { fg = c.error, bg = 'NONE', bold = true, })
   hl(0, "Statement", { fg = c.purple, bg = 'NONE' })
-  hl(0, "Identifier", { fg = c.fg, bg = 'NONE' })
+  hl(0, "Identifier", { fg = c.light_blue, bg = 'NONE' })

Is there any consideration to let @symbol be white? If not, the colorscheme could be updated a little bit.

@YaQia
Copy link
Author

YaQia commented Feb 4, 2023

Oh god, I just realized the treesitter of make is not implemented correctly and lack of some essential highlighting groups. e.g. define is not highlighted

Without treesitter, the highlighting group still links to Identifier, so I might keep the value.
image

@YaQia YaQia changed the title Could Makefile treesitter highlight support be added? Could Identifier highlight support be added? Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant