Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure deepdisc is properly installed #2

Closed
drewoldag opened this issue Nov 2, 2023 · 1 comment
Closed

Ensure deepdisc is properly installed #2

drewoldag opened this issue Nov 2, 2023 · 1 comment
Assignees
@drewoldag

Comments

@drewoldag
Copy link
Collaborator

Currently the only defined dependency for this package is deepdisc. However, it's not clear that (for instance CI is running) that deepdisc is actually being pip installed correctly. For instance, there's no place where detectron2 or scarlet is installed.

The only test at this point is toothless. So we should introduce any trivial test that will ensure that deepdisc is actually installed. I'm not 100% confident, but I would guess that this will require some changes to the CI workflows to match the dependency install process defined in the CI in the deepdisc repo.
@drewoldag drewoldag changed the title Implement any trivial test that uses deepdisc Ensure deepdisc is properly installed Nov 2, 2023
@drewoldag drewoldag self-assigned this Nov 9, 2023
@drewoldag drewoldag mentioned this issue Nov 9, 2023
Merged
4 tasks
@drewoldag
Copy link
Collaborator Author

This work was addressed in PR #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewoldag drewoldag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drewoldag