Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return "truth catalog" info / save truth catalog #129

Open
NiallMac opened this issue Feb 1, 2021 · 6 comments
Open

Return "truth catalog" info / save truth catalog #129

NiallMac opened this issue Feb 1, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@NiallMac
Copy link
Collaborator

NiallMac commented Feb 1, 2021

For analysis of the sims, we'll want to know what exactly was drawn where. So I think for each exposure we'd want to return this information as well as (or as part of) seobs. At a minimum, we'd want, for each object drawn,

  • Whether it was a galaxy or star
  • The index from the galaxy/star catalog`
  • ra/dec
  • Any randomly generated properties that can't be reconstructed from the input catalog and the index e.g. if a random rotation is applied before drawing
    For the convenience though, we might just want to retain all the information about the object e.g. flux, morphology...

Also add tools for saving this stuff to file.

Let me know thoughts/preferences about how we set this stuff up, and whether I should take a crack at this or @esheldon or @beckermr you'd rather do it.

@esheldon
Copy link
Collaborator

esheldon commented Feb 1, 2021

Thanks Niall. Can you please list the primary use cases for this catalog? It will help to understand what is needed and how to implement it.

We don't do i/o in this library, so we would rather provide the ability to get the catalog and then the user can do the i/o

@NiallMac
Copy link
Collaborator Author

NiallMac commented Feb 1, 2021

Good question. So my particular use case was for the n_gamma(z) calculations we've discussed. Specifically - I want to get an estimate of the redshift distribution of objects detected in a given simulation. It doesn't need to be perfect (because what does that mean with blending anyway), so being able to position-match the output catalog to the inputs, and then grab the corresponding redshifts, would be a sufficient and the most straightforward way to do this.

I imagine this would also be useful generally for testing that the simulation code is doing what we expect. Especially in simplified sims e.g. without blending, comparing input and output objects is a decent approach to doing so I think, but for that we need to keep track of what input objects we simulated and where.

@beckermr
Copy link
Collaborator

beckermr commented Feb 1, 2021

Yes. My student is adding this same set of analysis steps to the old mdet code as well. The positions and redshifts of each object should be sufficient to start. Estimates of the object's size might be useful for helping to differentiate things that are very blended versus not.

@esheldon
Copy link
Collaborator

Note we now do return bright_info, we could extend this to all objects

@NiallMac
Copy link
Collaborator Author

Sounds good - I can have a go at this - I'll just copy the way this is done for bright_info unless you have alternative suggestions?

@esheldon
Copy link
Collaborator

that sounds fine, add a new entry to the output dictionary, e.g. truth_catalog or whatever.

@esheldon esheldon added pie-in-the-sky Stretch goal, help is needed from an expert enhancement New feature or request and removed pie-in-the-sky Stretch goal, help is needed from an expert labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants