Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add version to the filename suffix #155

Open
stuartmcalpine opened this issue Oct 11, 2024 · 2 comments
Open

Don't add version to the filename suffix #155

stuartmcalpine opened this issue Oct 11, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@stuartmcalpine
Copy link
Collaborator

Currently files when they are registered with an automatically generated name have the version appended to the end of the file name.

This in theory messes up the filename suffix, if an application was to use that.

Could:

  • Put dataset files also into directories first with the auto generated name and version, then put the file into that directory
  • Name the directories based on the executions and have the files go into their execution folders (however as you can append datasets to executions after, theres no guarantee of filename conflicts later)
@JoanneBogart
Copy link
Collaborator

I'd like to also make a somewhat related change to ensure that automatically-generated paths don't clash with user-supplied paths: we make a subdirectory, say called .gen_paths, under the owner level, and all generated names go under there. We would also need to disallow any user paths starting with that string.

@stuartmcalpine
Copy link
Collaborator Author

Started addressing this in #159

I'd like to also make a somewhat related change to ensure that automatically-generated paths don't clash with user-supplied paths: we make a subdirectory, say called .gen_paths, under the owner level, and all generated names go under there. We would also need to disallow any user paths starting with that string.

I have added this to the PR. Now auto generated relative paths start with a .gen_paths directory. There is also a check making sure users cannot start their relative paths with that directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants