From 128b83b930fa8731a618bf1680dac927ea6150bf Mon Sep 17 00:00:00 2001 From: Dylan Copeland Date: Fri, 17 May 2024 21:23:36 -0700 Subject: [PATCH] Minor fixes. --- lib/linalg/Matrix.cpp | 4 ++-- unit_tests/test_QR.cpp | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/linalg/Matrix.cpp b/lib/linalg/Matrix.cpp index 027d24e10..b1abedb53 100644 --- a/lib/linalg/Matrix.cpp +++ b/lib/linalg/Matrix.cpp @@ -1124,13 +1124,13 @@ Matrix::calculateNumDistributedRows() { std::unique_ptr Matrix::qr_factorize() const { std::vector QR; - qr_factorize(true, QR); + qr_factorize(false, QR); return std::unique_ptr(QR[0]); } void Matrix::qr_factorize(std::vector> & QR) const { - std::vector QRraw; + std::vector QRraw; // Raw pointers qr_factorize(true, QRraw); QR.clear(); for (int i=0; i<2; ++i) diff --git a/unit_tests/test_QR.cpp b/unit_tests/test_QR.cpp index cdf4fe00f..ec52b5d67 100644 --- a/unit_tests/test_QR.cpp +++ b/unit_tests/test_QR.cpp @@ -121,8 +121,6 @@ TEST(QRfactorizeTest, Test_QR) EXPECT_NEAR(maxError, 0.0, 1.0e-15); - if (rank > 0) return; - EXPECT_EQ(R->numRows(), num_columns); EXPECT_EQ(R->numColumns(), num_columns);