-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Handling of clamped arrays? #3030
Labels
type: bug 🐞
Errors in functionality
Comments
4 tasks
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
When creating data arrays from Uint8ClampedArray, VTK infers the texture type to be a float texture, not a UCHAR. This is (I suppose) because VtkDataTypes.UNSIGNED_CHAR is "Uint8Array", so the data type does not get properly detected when creating the texture.
Steps to reproduce
Detailed Behavior
getDefaultTextureInternalFormat in Rendering/OpenGL/RenderWindow.js doesn't match the data type to be uchar, and falls down to the default float case.
Expected Behavior
The OpenGL texture uses the right data type (UCHAR), that does not require the
OES_texture_float_linear extension
.Environment
The text was updated successfully, but these errors were encountered: