Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: WykoOPDReader v0.1.2 #118120

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 6da23c8c-444c-4310-aaa6-9150b66cb193
Repo: https://github.com/jaakkor2/WykoOPDReader.jl.git
Tree: 293dcdf1811b3cbc1210dbafac04712878108375

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Oct 26, 2024

Thank you for submitting your package! However, could you extend the documentation in the README a little bit more? It would probably be good for "Wyko OPD profilometer datasets" to be a link to some page that explains the format and gives some context. Please also explain what the type of data is that results from readopd, and what one might be able to do with that object.

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Oct 26, 2024
@jaakkor2
Copy link
Contributor

[noblock] Thank you @goerz for taking the time to review new package entries. Now I found Matlab script many by Veeco https://mtl.mit.edu/pipermail/labnetwork/attachments/20110711/1f04a0e6/attachment.ksh that seems be the best available description of the OPD format. I added a link to that to README.md. Also, docstring for readopd had already a plotting example. Hopefully these answers your concerns.

@goerz
Copy link
Member

goerz commented Oct 27, 2024

Closing in favor of #118158

In the future, please do not change the version number when addressing issues with the registration.

Hopefully these answers your concerns

My question was about the type of data. It seems like it might be Dict. You'll want to document that, and which keys the dict has, and what information the dict values contain.

@goerz goerz closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants