Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow general backends in BlockSkylineMatrix #27

Open
dlfivefifty opened this issue Mar 15, 2019 · 1 comment
Open

Allow general backends in BlockSkylineMatrix #27

dlfivefifty opened this issue Mar 15, 2019 · 1 comment
Assignees

Comments

@dlfivefifty
Copy link
Member

I have a need for non-Vector (in fact, infinite) backends in BlockSkylineMatrix so am planning to template out the storage, just as BandedBlockBandedMatrix and BlockArray allow general backends.

While I'm at it, there's a question whether we want to make the type signature more resemble the new BlockArray:

BlockArray{T, N, R <: AbstractArray{<:AbstractArray{T,N},N}, BS<:AbstractBlockSizes{N}}

That is, we have two options:

  1. BlockSkylineMatrix{T, R <: AbstractVector{T}, LL<:AbstractVector{Int}, UU<:AbstractVector{Int}}
  2. BlockSkylineMatrix{T, R <: AbstractVector{T}, BS<:AbstractBlockSizes{2}}

Option 2 is closer to the new BlockArray. @jagot Any reason to prefer Option 1?

@dlfivefifty dlfivefifty self-assigned this Mar 15, 2019
@jagot
Copy link
Contributor

jagot commented Mar 15, 2019

Not that I can think of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants