Allow use of a url and subdir in [sources] #4039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monorepos exist, so we shouldn't complain when somebody tries to combine the url and subdir parameters.
|
This might be all that is needed but would be good with a test to confirm. |
|
I notice in the tests in |
|
duplicate of #3826? |
|
Huh, looks a bit like it. I assumed no fix was around from the state of #4026. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monorepos exist, so we shouldn't complain when somebody tries to combine the url and subdir parameters.
I think this is all that's needed to close #4026. These additions are just from looking through #3783 for suspicious omissions.