Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append bundled depots to places where we empty it during tests #3807

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Append bundled depots to places where we empty it during tests #3807

merged 3 commits into from
Jul 26, 2024

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Feb 23, 2024 •
edited by IanButterworth
Loading

Fixes #3969

I am thinking we might be precompiling stdlibs over and over since we won't find the precompile files for those if we do not have the bundled depots in the depot path.

If this is useful this should have a bit smaller CI runtime.

@KristofferC
Copy link
Member Author

I don't think this matters since we turn off auto precompile for the tests.

@KristofferC KristofferC mentioned this pull request Jul 25, 2024
Open
@IanButterworth
Copy link
Member

Trying a fix. I think that test was installing the registry into the shared depot. First time this was seen is after that test

┌ Info: /Users/runner/hostedtoolcache/julia/nightly/aarch64/share/julia
│   readdir(d) =
│    8-element Vector{String}:
│     "base"
│     "base.cache"
│     "cert.pem"
│     "compiled"
│     "julia-config.jl"
│     "registries"
│     "stdlib"
└     "test"

@IanButterworth IanButterworth mentioned this pull request Jul 25, 2024
Merged
@IanButterworth
Copy link
Member

Depends on #3972

@IanButterworth IanButterworth marked this pull request as draft July 25, 2024 17:51
@IanButterworth IanButterworth changed the title test appending bundled depots to places where we empty it Append bundled depots to places where we empty it during tests Jul 25, 2024
@IanButterworth IanButterworth marked this pull request as ready for review July 25, 2024 19:02
@IanButterworth
Copy link
Member

Not sure why this one is still happening. We appear to be adding the correct Pkg there

Precompiling ArtifactOverrideLoading...
  67218.6 ms  ✓ Pkg
  1 dependency successfully precompiled in 67 seconds. 24 already precompiled.
  1 dependency precompiled but a different version is currently loaded. Restart julia to access the new version

@IanButterworth
Copy link
Member

27m down to 15m on MacOS CI. Nice

@IanButterworth IanButterworth merged commit 8c1f45d into master Jul 26, 2024
7 checks passed
@IanButterworth IanButterworth deleted the kc/depot branch July 26, 2024 02:35
@KristofferC
Copy link
Member Author

Nice indeed!

IanButterworth pushed a commit that referenced this pull request Aug 5, 2024
@KristofferC @IanButterworth
Append bundled depots to places where we empty it during tests (#3807)
a3a34d6 
* append bundled depots to places where we empty it

* one more from workspaces tests

* use Artifacts not Pkg.Artifacts in test to avoid reprecompilation

---------

Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
(cherry picked from commit 8c1f45d)
@IanButterworth IanButterworth mentioned this pull request Aug 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pkg CI does a lot of re-precompiling stdlibs
2 participants
@KristofferC @IanButterworth