-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CsvContext.Configuration.ShouldQuote
is not used
#2292
Comments
CsvContext.ConfigurationShouldQuote
is not usedCsvContext.Configuration.ShouldQuote
is not used
The only way to set those values is to pass a Changes were made in v20 to make
It looks like copying the config values to a local private copy after passing |
Would it make sense then for CsvContext to expose a read-only version of the configuration? |
I'm using v30.0.1 but I believe this is true for the latest.
This seems to use the
ConfigurationFunctions.ShouldQuote
instead of my delegate, I believe because it gets copied here locally on construction of CsvWriter:CsvHelper/src/CsvHelper/CsvWriter.cs
Line 121 in 852bd46
I'm updating from v15 to v30, so I'm still trying to figure out all the changes. Is the
Context.Configuration
meant to expose mutable fields on the writer's configuration? If so, should theWriteField
method useconfiguration.ShouldQuote
instead of storing a local copy on construction?I understand I can set the configuration and pass it to CsvWriter, but seems like
Context.Configuration.ShouldQuote
should not be settable if its not intended to take effect.The text was updated successfully, but these errors were encountered: