Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel downloads in progress when threads removed #41

Open
Issung opened this issue Oct 22, 2023 · 0 comments
Open

Cancel downloads in progress when threads removed #41

Issung opened this issue Oct 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Issung
Copy link
Owner

Issung commented Oct 22, 2023

New download managers from bugfix/imagelink-download-duplicates-raceconditions-threadsafety branch will allow cancellation of downloads in progress, and stopping future downloads too.

A few things are needed:

  • Need to use a download technique that supports cancellation. Probably need to swap to using HttpClient.
    • Will also need to adjust all download exception handling.
  • When user changes "SaveHTML" setting, cancel thread html downloads if false.
  • When a thread is removed, cancel image downloads and cancel html download.
  • Cancel when user initiates removal, so no more exceptions happen regarding renaming folders.

Search code for comments labeled with this issue's number.
@Issung Issung added the enhancement New feature or request label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Issung