Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output not visible in GitHub Actions #88

Open
giarc3 opened this issue Dec 8, 2022 · 1 comment
Open

Output not visible in GitHub Actions #88

giarc3 opened this issue Dec 8, 2022 · 1 comment
Labels
bug Something isn't working needs-design

Comments

@giarc3
Copy link
Member

giarc3 commented Dec 8, 2022

File decryption output is not visible when using ironhide in GitHub Actions. We use this function for our output (or println_paint):

pub fn print_paint(paint: yansi::Paint<String>) {
    // only print to stdout if we're not being piped somewhere
    if atty::is(atty::Stream::Stdout) {
        print!("{}", paint);
    }
}

I assume the condition is failing in this environment, in which case we print out nothing.
The atty also seems abandoned.

@cjyar cjyar added the bug Something isn't working label Dec 14, 2022
@skeet70
Copy link
Member

skeet70 commented Jul 19, 2023

We worked around this in IronCoreLabs/ironhide-actions like this and like this. We still don't have a solution for Windows, and either way the issue still stands.

We'd need a design of how we want to fix this. It's common to use isatty to toggle features like sending colors or not, but it isn't common to use it to decision sending output at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-design
Projects
None yet
Development

No branches or pull requests

3 participants