-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query-builder): support for nested queries and other improvements #14647
base: master
Are you sure you want to change the base?
Conversation
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…ee change" This reverts commit 98b08df.
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
Result: The dialog to change the group operator is not shown. Only the group line style changes to selected. This may be by design but I still think we should probably discuss this UX. |
The row to add a condition is shown but the following error is logged in the console (3 times): |
Result: All inputs and buttons in the new group are disabled. |
Result: All inner conditions disappear from the UI. The tree doesn't seem to change. |
The button is not disabled on switching to In/Not In conditions (as the value the input is). The following error is logged in the console on clicking it: |
…ry-builder-simple-select-from-new
…ry-builder-simple-select-from-new
* refactor(query-builder): simple select from * test(query-builder): fix several legacy tests --------- Co-authored-by: INFRAGISTICS\IPetrov <IPetrov@infragistics.com> Co-authored-by: igdmdimitrov <dmdimitrov@infragistics.com>
On behalf of Javier. |
…mitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
@igdmdimitrov After deleting all inner conditions and submitting the parent, the two buttons for adding a group remain.
The buttons stay: |
Result: In addition to removing the empty condition, the return fields are also cleared. Expected result: Return fields not to be changed. |
Closes #14642
Closes #14979
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)