Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of log files under edit-drafts folder is over growing #10138

Open
JeyaSam opened this issue Nov 24, 2023 · 2 comments · May be fixed by #10890
Open

Number of log files under edit-drafts folder is over growing #10138

JeyaSam opened this issue Nov 24, 2023 · 2 comments · May be fixed by #10890

Comments

@JeyaSam
Copy link

JeyaSam commented Nov 24, 2023 •
edited by pdurbin
Loading

What inspired the request?
Under /usr/local/payara5/glassfish/domains/domain1/logs/edit-drafts folder, the number of files is overgrowing (around 10K).

What existing behavior do you want changed?

  1. It will be helpful if some information is provided under https://guides.dataverse.org/en/6.0/admin/monitoring.html#edit-draft-versions-logging for managing these files.
    Do not know what are the scenarios or there are any APIs to use/retrieve the information logged by these files.

Since each file adds on to the change history of a dataset, deleting them based on date/time may not be correct.

  1. Instead of creating one file for each change, one edit-draft file per dataset doi can be maintained to reduce the number of files.

  2. It will be helpful if there is an configuration option to turn off this feature if people don't want to use it.
    For e.g.:
    curl -X PUT -d 'true' http://localhost:8080/api/admin/settings/:EditDraftFilesEnabled

Any brand new behavior do you want to add to Dataverse?

Any open or closed issues related to this feature request?

related google group post: https://groups.google.com/g/dataverse-community/c/eCii8K3LYJo/m/JT6JiCPEHQAJ
@qqmyers qqmyers linked a pull request Sep 27, 2024 that will close this issue
Draft
@qqmyers
Copy link
Member

qqmyers commented Sep 27, 2024

@JeyaSam - can you confirm whether you agree that adding a feature flag to disable edit-draft logging is enough to close this issue? (I've added a line in the #10890 description that will automatically close this issue when that PR is merged. I'll remove it if you think further work, e.g. to consolidate logging into one file should be done before this issue can close. )

@JeyaSam
Copy link
Author

JeyaSam commented Sep 30, 2024

@qqmyers - thanks for adding the flag. Adding of the feature flag to disable edit-draft logging will be helpful for the users who do not use the edit-draft log files. This flag needs to be there even if you further improve to consolidate logging into one file. Hence you can add it.
Actually, I couldn't find much information on how this logged information is used, so you can prioritize on consolidation based on the usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dataset Edit Performance Improvements GlobalDataverseCommunityConsortium/dataverse
2 participants
@qqmyers @JeyaSam