-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.entities()
typedef update
#690
Comments
I'm partial to doing (b) now via #688, and then doing (a) later, unless (a) can be done in the near term. |
I think we are favoring solution 'c'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Currently, the return type definitions for
.entities()
methods are inaccurate. it saysIterable[CURIE]
, but it is also possible for it to return "quoted URIs" (example:<http://identifiers.org/hgnc/10004>
).Possible solutions
a. Fix so that URIs, not quoted URIs are returned, and update type def
Union[CURIE, URI]
b. Add new type for quoted URIs and update type def
Union[CURIE, QUOTED_URI[
c.
IDENTIFIER
CURIE
toIDENTIFIER
, such that this is used universally in signatures. This will be a large diff, but it will not affect runtimeIDENTIFIER = CURIE | QUOTED_URI
. Again, this is typing information that does not affect runtime, but it helps make the intentions clearAdditional details
Context / discussion
Chris:
Joe:
Related
The text was updated successfully, but these errors were encountered: