-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming of some attributes/types are deceptive #16
Comments
@Alex-Cook4, depending on a specific environment, the role of a speaker (Agent/Client; Trader/Client) can possibly be retrieved and assigned to each individual rtpStreamId. Regarding the speakerId, isn't it required for environments where speaker diarization is required? In that case, there may be multiple different values of speakerId (1,2,3...) for each individual rtpStreamId. I agree with renaming suggestions with one minor correction: rtpStreamStartTime, not rtpStreamsStartTime. What'd you think? |
@mgorbat Thanks for the input.
Is that true coming from the RTP packets themselves? I understand that we can get that information from a CTI feed that we later correlate with the identifiers in the RTP Stream, but if that's what you're talking about, then those attributes shouldn't show up until later in my opinion. Regarding:
Diarization results are currently placed in the list<int32> utteranceSpeakers since a given utterance may have multiple speaker identifiers. |
@Alex-Cook4 Agree with removal of speakerId, as I haven't noticed there is an attribute for this already. |
In that case, I'm fine with keeping the role attribute as an indicator that this is something that can potentially be set in customized situations. My updated proposal would be the following:
|
I would also like to add a:
|
I haven't started changing attribute names yet because I want to try to keep the work backwards compatible for now. This issue is more for guidance when we decide we can really overhaul things.
Since I keep getting confused, I'm working on adding documentation on what each type means. I will call out attributes that I believe are misleading.
In the Utterance:
I recommend the following:
As I see other types/attributes I think could be cleaned up, I will add them to this issue.
The text was updated successfully, but these errors were encountered: