Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key rotation logic and alias key selection logic #12

Open
cmlight opened this issue Jun 10, 2021 · 1 comment · Fixed by #13
Open

Fix key rotation logic and alias key selection logic #12

cmlight opened this issue Jun 10, 2021 · 1 comment · Fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@cmlight
Copy link
Contributor

cmlight commented Jun 10, 2021

Currently this isn't working correctly, so the demo doesn't always work. For the beta test, we'll only worry about the domain having one key present. Longer term, we'll upgrade to what's outlined in the design doc for key management and rotation.

@cmlight cmlight added the bug Something isn't working label Jun 10, 2021
@cmlight cmlight added this to the Public comment MVP milestone Jun 10, 2021
@cmlight cmlight self-assigned this Jun 10, 2021
@cmlight cmlight reopened this Jun 10, 2021
@manigandham
Copy link
Contributor

Adding comments found in code:

See the design doc for the keyring configuration file concepts and key lifecycle state machine. Basically we want to use the key in the KEY_STATUS_ACTIVE_PRIMARY state, as it has been published in DNS for adequate time for counterparties verifying our signature to have crawled it from DNS. Ideally rotation to a new signing key doesn't happen all-at-once but can instead be rolled out in a controlled fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants