-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow installing formulae from paths without HOMEBREW_DEVELOPER #18371
Comments
Yea, installing formulae from paths is buggy and shouldn't be used. We should probably remove the ability to do that at some point. To avoid this, put FORMULA_DIR="$(brew --repository)/Library/Taps/thefanatr/homebrew-your-tap-name/Formula/"
mkdir -p "$FORMULA_DIR"
mv ../homebrew-slang/slang.rb "$FORMULA_DIR"
brew install thefanatr/your-tap-name/slang |
Agreed 👍🏻. Rescoping this issue to that. |
…EVELOPER If `HOMEBREW_DEVELOPER` is not set, then let's make `HOMEBREW_FORBID_PACKAGES_FROM_PATHS` default to true. I used a custom implementation here because we don't currently support setting defaults for booleans. (See calls to `define_method` below.) Closes #18371.
brew doctor
outputVerification
brew doctor
output" above saysYour system is ready to brew.
and am still able to reproduce my issue.brew update
twice and am still able to reproduce my issue.brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.brew config
outputWhat were you trying to do (and why)?
I wrote a formula for Slang here. When debugging the formula locally I noticed two things: if I asked for
brew info slang
when installed, I would get the information fors-lang
; and importantly that if I install from a local ruby file likebrew install --formula --head ./slang.rb
, then after successfully running the install, it would say it will try to dobrew cleanup slang
, but this would fail by apparently trying to runcleanup
ons-lang
. When the formula is installed remote withbrew install --formula --head thefanatr/slang/slang
, this does not happen.What happened (include all command output)?
brew install --head --formula ../homebrew-slang/slang.rb
Error
brew cleanup slang
but
brew install --head thefanatr/slang/slang
No Error
brew cleanup slang
What did you expect to happen?
The no error version for the local formula case.
Step-by-step reproduction instructions (by running
brew
commands)The text was updated successfully, but these errors were encountered: