Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong sound plays on auto-advance #364

Closed
Hanziness opened this issue Mar 11, 2024 · 0 comments · Fixed by #365
Closed

Wrong sound plays on auto-advance #364

Hanziness opened this issue Mar 11, 2024 · 0 comments · Fixed by #365
Labels
bug 🐛 Something isn't working

Comments

@Hanziness
Copy link
Owner

Introduced in #361, when the the auto-advance behavior jumps to the next section, the wrong sound plays (the end sound of the new section instead of the finished section). To fix this, the finished section's end sound should play in all cases.
@Hanziness Hanziness added the bug 🐛 Something isn't working label Mar 11, 2024
@Hanziness Hanziness linked a pull request Mar 11, 2024 that will close this issue
fix(ticker): Fix wrong sound playing on auto-advance #365
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ticker): Fix wrong sound playing on auto-advance Hanziness/FocusTide
1 participant
@Hanziness