Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection quest drops aren't showing when you complete tasks #1310

Open
saraolson opened this issue Jul 12, 2023 · 1 comment
Open

Collection quest drops aren't showing when you complete tasks #1310

saraolson opened this issue Jul 12, 2023 · 1 comment

Comments

@saraolson
Copy link
Collaborator

you should get a toast that tells you when you get a pending item for your collection quest, but that toast doesn't show for me. i just have to go to my party and see if i have any pending items after i complete my tasks

@tjb
Copy link
Contributor

tjb commented Apr 9, 2024

investigating this i see we are doing a toast for found items in TaskRepositoryImpl#126

            if let drop = response.temp?.drop {
                var dialog = drop.dialog
                if dialog == nil {
                    dialog = "You found a \(drop.key ?? "")"
                }
                ToastManager.show(text: dialog ?? "", color: .gray)
            }

the response looks has a shape of TaskResponseTempProtocol but the quest prop only has a progressDelta.

@phillipthelen is there somewhere else in the code that sends a signal when a pending item is found? Or would require an update to the backend to include this information and then modify TaskResponseQuestProtocol?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants