Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transitdata repositories to use organization-level secrets #276

Open
2 of 4 tasks
LofhJann opened this issue Apr 6, 2023 · 4 comments
Open
2 of 4 tasks

Update transitdata repositories to use organization-level secrets #276

LofhJann opened this issue Apr 6, 2023 · 4 comments
Labels
ADO Will be moved to ADO

Comments

@LofhJann
Copy link

LofhJann commented Apr 6, 2023

Currently transitdata-vehicleposition-processor uses repository-level secrets for docker-hub. These should be replaced with corresponding organization-level secrets from HSLdevcom organization.

Replace following

  • secrets.DOCKER_USERNAME with secrets.TRANSITDATA_DOCKERHUB_USER
  • secrets.DOCKER_PASSWORD with secrets.TRANSITDATA_DOCKERHUB_PASSWORD

Tasklist:

  • Update to dev branch
  • Test it works in dev branch
  • Merge changes to release branch (master?)
  • Remove old secrets from repository (contact admin if necessary)
@mjaakko
Copy link
Contributor

mjaakko commented Apr 12, 2023

The same update should be done for all Transitdata repos

@teemu8655 teemu8655 added the ADO Will be moved to ADO label May 19, 2023
@teemu8655
Copy link

Organization secrets allowed to all transitdata repos. Next @LofhJann can remove repo sercets.

@mjaakko
Copy link
Contributor

mjaakko commented May 19, 2023

Correct config:

          username: ${{ secrets.TRANSITDATA_DOCKERHUB_USER }}
          password: ${{ secrets.TRANSITDATA_DOCKERHUB_TOKEN }}

@LofhJann LofhJann changed the title Update transitdata-vehicleposition-processor to use organization-level secrets Update transitdata repositories to use organization-level secrets May 22, 2023
@LofhJann
Copy link
Author

All transitdata repos should be now updated to use org-level repos in develop branches. Master/main is still using old secrets so they shouldn't be removed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Will be moved to ADO
Projects
None yet
Development

No branches or pull requests

3 participants