Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that workplace shares are not larger than one #453

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

zptro
Copy link
Collaborator

@zptro zptro commented May 16, 2022

This halts the model run if workplace shares larger than one are detected. As MAL 2019 data contains such anomality, we should either wait with pulling this or somehow change it into a warning.

@zptro zptro requested a review from johpiip May 16, 2022 12:59
@zptro zptro linked an issue May 16, 2022 that may be closed by this pull request
Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change log.error to log.warn here but it might deteriorate land-use data quality if people do not notice warnings.

@zptro zptro added this to the v5.0 milestone Feb 22, 2023
@zptro zptro changed the base branch from olusanya to helmet-5 October 17, 2024 10:37
@zptro zptro merged commit c69919a into helmet-5 Oct 17, 2024
2 checks passed
@zptro zptro deleted the feat/workplace_share_check branch October 17, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workplace shares are not checked
2 participants