Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cannot set Block display value #6039

Open
2 tasks done
Gryphonn opened this issue Aug 6, 2024 · 4 comments
Open
2 tasks done

BUG: Cannot set Block display value #6039

Gryphonn opened this issue Aug 6, 2024 · 4 comments

Comments

@Gryphonn
Copy link

Gryphonn commented Aug 6, 2024

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome 126

Reproducible demo link

https://jsfiddle.net/Gryphonn/ob1pznh6/

Describe the bug

How to reproduce the bug?

  1. Select any word.
  2. Wrap it for style.
  3. Keep this word selected.
  4. Go to General -> Display
  5. I want Block. I click Block but nothing happens.

What is the expected behavior?
Display value must be either empty so that I can instantly choose whatever I need.
Or it must show the current actual display value of the selected text. Which is Inline in this case and not Block.

What is the current behavior?
Currently I need to click twice.
First, click anything except Block. The display field is activated.
Then I should click Block.

If is necessary to execute some code in order to reproduce the bug, paste it here below:

// your code here

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Gryphonn Gryphonn changed the title BUG: BUG: Cannot set Block display value Aug 6, 2024
@danstarns
Copy link
Member

Hi @Gryphonn,

I tried to reproduce your issue but the steps aren't that clear, please rephrase.

@Gryphonn
Copy link
Author

Gryphonn commented Aug 8, 2024

Hi @Gryphonn,

I tried to reproduce your issue but the steps aren't that clear, please rephrase.

bandicam.2024-08-08.21-07-14-667.mp4

@danstarns
Copy link
Member

Hi @Gryphonn,
I tried to reproduce your issue but the steps aren't that clear, please rephrase.

bandicam.2024-08-08.21-07-14-667.mp4

Thank you for a detailed report 🙏

It looks like we should better handle the default display so you don't have to first change to another display and back again.

@artf
Copy link
Member

artf commented Aug 9, 2024

Yeah, the issue is here:

['display', { type: this.typeSelect, default: 'block', options: this.opstDisplay }],

Would it make sense to add a new option like initial and make it the default one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants