Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable (or adjust) dependabot. #66

Open
bwplotka opened this issue Jul 3, 2023 · 2 comments
Open

Disable (or adjust) dependabot. #66

bwplotka opened this issue Jul 3, 2023 · 2 comments
Assignees

Comments

@bwplotka
Copy link
Collaborator

bwplotka commented Jul 3, 2023

The dependabot settings are inherited from upstream and this bot does not necessarily help for forked project like this.

The reason is that we get spam of updates of single package updated on EACH release branch (rate limited by dependabot). This causes issues:

  1. It's not scalable to update single package in random time on random release branch especially manually. In fact we were not touching it so bot paused:

image

  1. Every single update is essentially a "patch" that will make it much harder to sync e.g. patch version from Prometheus later on. It is also unsure if we should trigger expensive and time consuming release for each update or not?

I would suggest we disable the bot for now. If we need security updates on certain deps on certain release we might want to rather fix upstream OR manually patch version and only do that if absolutely necessary.

If we really want spam of PRs with dep updates and we want to all release branches to have all the latest deps (I don't think we want/need that), I would suggest we reconfigure dependabot to do batch upgrades, so it's managable.

@TheSpiritXIII
Copy link
Member

Why? We've been merging Dependabot issues in the prometheus-engine repository. They're really useful, especially since at the end of this month, we'll need to start merging those to meet vulnerability requirements.

@bwplotka bwplotka changed the title Disable dependabot. Disable (or adjust) dependabot. Jul 5, 2023
@bwplotka
Copy link
Collaborator Author

bwplotka commented Jul 5, 2023

Yea, sorry for not explaining why, I should have updated the description. Edited it in (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants