Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestones (and maybe a changelog) #44

Open
pdurbin opened this issue Mar 4, 2020 · 2 comments
Open

Milestones (and maybe a changelog) #44

pdurbin opened this issue Mar 4, 2020 · 2 comments

Comments

@pdurbin
Copy link
Member

pdurbin commented Mar 4, 2020

Now that a brand new file type has been added in 88b45d6 (thanks, @qqmyers !!) in response to https://groups.google.com/d/msg/dataverse-community/alcWrU246C8/ISFbJSMGCgAJ the default branch ("master") as of this writing, is ahead of the latest release ( https://github.com/GlobalDataverseCommunityConsortium/dataverse-previewers/tree/1.0 ).

I would suggest that we start using milestones. Datamons (Keepers? What do we call Dataverse enthusiasts?) are probably aware that core Dataverse uses milestones: https://github.com/IQSS/dataverse/milestones

I can also create a separate issue about keeping a change log, which is highly related. Or we could combine them all in one. My favorite resource for this is https://keepachangelog.com

@qqmyers
Copy link
Member

qqmyers commented Mar 4, 2020

@pdurbin, FWIW, I decided to update master since this was 'only' a change to the readme doc. If you're willing, I think it would be great if we have a policy that changes to master have to undergo review by some set of committers (currently @jonc1438, you and I are the only people with write access and you and I are the two in that set that have changed code, so 'all' 2 or 3 of us is 'some set' for now.)
Given that the readme change nominally affects functionality (if you follow the instructions you now get audio/wav support), I guess it makes sense to add a new tag at least (would you recommend a release as well? given semantic versioning, would this be 1.0.1 or 1.1?).
Adding a basic changelog is probably a good idea too, but I guess I question the value of milestones for volunteer projects - other than as an aspirational goal, we don't have much control over what comes in when.
All that said, I think these repos should be managed by the team that's interested and involved, so for these or other mgmt things, if you're willing/able to put in the time to make them happen, it's an easier question for other committers (are you willing to give it a try).

@pdurbin
Copy link
Member Author

pdurbin commented Mar 5, 2020

😄

@qqmyers there's a lot to unpack there but let me link you to a place where I experimented with milestones in a way that makes sense to me: https://github.com/IQSS/dataverse-metrics/milestones

In short, I create the next milestone right after I make a release, even if I don't merge anything for a while.

Anyway, please take a look and we can discuss! Did I mention Harvard has Zoom now? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants