-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing labels to be renamed from an existing label #492
Labels
Comments
Willing to PR this, awaiting for approval. |
davidzwa
added a commit
to davidzwa/GitReleaseManager
that referenced
this issue
Jun 10, 2023
davidzwa
added a commit
to davidzwa/GitReleaseManager
that referenced
this issue
Jun 10, 2023
…s a valid label
davidzwa
added a commit
to davidzwa/GitReleaseManager
that referenced
this issue
Jun 10, 2023
…label update/create logic
6 tasks
@davidzwa I have added a comment to your PR, but also going to reply here... I think this is a good idea. Let me take a look at your PR, and I will get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Detailed Description
I propose a extension of the label array model in the Configuration. Specifically I aim to introduce GRM in existing repo's without deleting existing labels, but instead renaming them automatically from old names.
Context
When introducing OR updating GRM labels on a repo, I would love to be able to rename existing labels to a new format. This allows me to update my existing repositories to a new label format with very little effort.
Possible Implementation
GitReleaseManager/src/GitReleaseManager.Core/Configuration/LabelConfig.cs
Line 8 in c0d8b8e
GitReleaseManager/src/GitReleaseManager.Core/Model/Label.cs
Line 8 in c0d8b8e
Add an optional field called RenameFrom, which when specified will take existing labels and run over the repository to rename them instead of deleting all and creating specific ones.
GitReleaseManager/src/GitReleaseManager.Core/VcsService.cs
Line 310 in c0d8b8e
Instead of deleting all, we determine which ones to delete and which ones to rename. Then we still delete the specific ones to be deleted, and secondly run over the ones to rename. We'd need a new IGithubClient method to do this.
I believe OctoKit has this, looking at its models:
Your Environment
The text was updated successfully, but these errors were encountered: