Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions triggers the message view transition #349

Open
ondrejkorol opened this issue Aug 13, 2023 · 2 comments
Open

Reactions triggers the message view transition #349

ondrejkorol opened this issue Aug 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ondrejkorol
Copy link

Following the issue of unreliable reactions on pinned messages, I noticed a weird behavior.

Adding or removing a reaction will result in the insert/removal transition of the whole message view, which shouldn't be the desired behavior. The nice thing would be to just animate the insertion/removal of the reactions view.

I know it's possible to turn off the animation for reactions via messageDisplayOptions.shouldAnimateReactions or disable the message view transition, but that just hides the issue.

The animation should be visible on the recording created in the example app. It affects any message that you react to.

GetStream Environment

GetStream Chat version: 4.35.1
GetStream Chat frameworks: StreamChat, StreamChatUI 4.35.1/main
iOS version: 15 – 16.5
Swift version: 5
Xcode version: 14.3.1
Device: doesn't matter

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-13.at.15.03.25.mp4
@martinmitrevski martinmitrevski transferred this issue from GetStream/stream-chat-swift Aug 14, 2023
@ondrejkorol
Copy link
Author

ondrejkorol commented Aug 14, 2023

The issue is present when developers enable the message transition via messageDisplayOptions:
E.g. in the Demo app, App Delegate:

 let utils = Utils(
            messageListConfig: MessageListConfig(
                messageDisplayOptions: .init(currentUserMessageTransition: .move(edge: .top)),
                dateIndicatorPlacement: .messageList)
        )
        streamChat = StreamChat(chatClient: chatClient, utils: utils)

@martinmitrevski
Copy link
Contributor

Thanks, we will look into this. In general, there's no support for transition per message, but just one for all messages. So in this case, probably we need to turn it off for reaction updates.

@laevandus laevandus self-assigned this Jun 13, 2024
@laevandus laevandus added the bug Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants