Typegen'd contract factories don't properly integrate storage slots for deployment methods

[nedsalk]

Given a typegen'd contract factory MyContractFactory that has some storage slots, the following works and includes the storage slots:

const factory = new MyContractFactory(wallet);
await factory.deploy();

However, the two examples below don't integrate the storage slots:

await factory.deployAsCreateTx();
await factory.deployAsBlobTx();

This is because the storage slots in the typegen outputs aren't properly integrated for these methods.

There are two possible solutions:

1. Override the two methods in the typegen'd contract factory the same way we do it with the deploy method,
2. Add a property on ContractFactory that can be overriden in the typegen'd factory and which would be read in all the deployment methods and merged with the deployOptions passed via arguments.

The second option looks better because it encapsulates the logic in ContractFactory, thereby having the typegen'd factory do as little runtime logic as possible. A possible implementation showcasing the core components is shown below.

// contract-factory.ts
export default class ContractFactory {
  // should it be protected or public?
  protected _deployOptions: DeployContractOptions = { };
  private getDeployOptions(deployOptions) { return mergeDeepRight(this._deployOptions, deployOptions); }

  // same pattern for all other public methods that have deployOptions as a parameter
  async deploy(deployOptions) {
    const options = this.getDeployOptions(deployOptions);
  }
}

// typegen/contracts/MyContractFactory.ts
export class MyContractFactory extends ContractFactory {
  protected _deployOptions: DeployContractOptions = {
    storageSlots: MyContract.storageSlots
  }
}

[arboleya]

@nedsalk Definitely option 1.