Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove unnecessary nonce from message gql queries #3298

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

fix!: remove unnecessary nonce from message gql queries #3298

wants to merge 10 commits into from
+14 −7

Conversation

maschad
Copy link
Member

@maschad maschad commented Oct 9, 2024 •
edited by danielbate
Loading

Release notes

In this release, we:

  • Optimized the getMessageByNonce provider endpoint

Summary

The nonce returned from the gql query was removed from the messageFragment operation as the parameter can actually be re-used in the function getMessageByNonce and a separate fragment was created for getMessage

Breaking Changes

  • Removed the nonce property from Provider.operations.getMessageByNonce(). This can still be retrieved by Provider.getMessageByNonce().

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:43pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:43pm

@github-actions github-actions bot added the bug Issue is a bug label Oct 9, 2024
@maschad maschad marked this pull request as draft October 9, 2024 19:11
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3298 will not alter performance

Comparing mc/fix/optimize-message-gql-queries (f44b062) with master (9ebd6c2)

Summary

✅ 18 untouched benchmarks

@maschad maschad marked this pull request as ready for review October 9, 2024 23:07
@maschad maschad enabled auto-merge (squash) October 10, 2024 00:23
@danielbate danielbate changed the title fix: remove unnecessary nonce from message gql queries fix!: remove unnecessary nonce from message gql queries Oct 10, 2024
@danielbate danielbate self-requested a review October 10, 2024 01:58
danielbate
danielbate previously approved these changes Oct 10, 2024
View reviewed changes
nedsalk
nedsalk previously approved these changes Oct 10, 2024
View reviewed changes
packages/account/src/providers/operations.graphql Outdated Show resolved Hide resolved
@maschad @nedsalk
update message fragment
809b0b7 
Co-authored-by: Nedim Salkić <nedim.salkic@fuel.sh>
@maschad maschad dismissed stale reviews from nedsalk and danielbate via 809b0b7 October 10, 2024 13:35
@petertonysmith94
Copy link
Contributor

This can be done at a later date - this optimization doesn't provide (much value).

auto-merge was automatically disabled October 10, 2024 15:15

Pull request was closed

@maschad
Copy link
Member Author

maschad commented Oct 15, 2024

Re-opening this so that we may re-introduce breaking changes at a later more appropriate date.

@maschad maschad reopened this Oct 15, 2024
@maschad maschad marked this pull request as draft October 15, 2024 17:39
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.12%(+0.01%) 70.02%(+0%) 75.09%(+0%) 76.25%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/generated/operations.ts 94.7%
(+0.04%)		 100%
(+0%)		 84%
(+0%)		 95.12%
(+0.03%)

@maschad
Copy link
Member Author

maschad commented Oct 15, 2024

Putting this as a draft since it's breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@maschad maschad

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize messages's graphql queries
5 participants
@maschad @petertonysmith94 @danielbate @nedsalk @arboleya