Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary PR deployments should have the source header populated with the PR number #3285

Open
petertonysmith94 opened this issue Oct 9, 2024 · 3 comments
Labels
chore Issue is a chore

Comments

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Oct 9, 2024

Summary

For temporary PR deployments, we should be able to identify via the Source header which version is being used. We could either:

  1. Read the version installed on the user's disk
  2. Add some automation to update the getBuiltinVersions return for temporary releases.

Originally posted by @nedsalk in #3282 (comment)

Follow up from: #3280

@petertonysmith94
Copy link
Contributor Author

petertonysmith94 commented Oct 9, 2024

Questions:

With option 1: how do we then add these to the header?
With option 2: this will cause tests to fail.

cc @nedsalk

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Oct 9, 2024
@petertonysmith94 petertonysmith94 changed the title Source header should have PR number Temporary PR deployments should have the source header populated with the PR number Oct 9, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Oct 9, 2024
@arboleya
Copy link
Member

arboleya commented Oct 9, 2024

This is low priority, especially given our moment, and can be circumvented by manually editing the version file.

@Dhaiwat10
Copy link
Member

Unassigning myself for now then

@Dhaiwat10 Dhaiwat10 removed their assignment Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

No branches or pull requests

3 participants