Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: cancellation of impersonation return to original user #23

Open
lostsnow opened this issue Jun 18, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@lostsnow
Copy link

lostsnow commented Jun 18, 2021

Feature Request

Is your feature request related to a problem? Please describe.

Currently User A(admin) can impersonate user B(normal user), but after impersonation can not return to original user A

Describe the solution you'd like

Remeber the original user(session/cookie) for cancellation of impersonation

@lostsnow lostsnow added the enhancement New feature or request label Jun 18, 2021
@clarkwinkelmann
Copy link
Member

That would be nice, but this won't be possible without reworking how the extension works.

Right now it starts a completely new session as the target user, and there's no difference between an impersonation or regular session.

An ideal implementation would be one where we don't actually start a new session and just override the actor with a special flag. This could also solve the other issue that currently the impersonated user is shown online and the account owner could kick the impersonator out by terminating all sessions or changing password. But that's a bit more complicated to implement than the current solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants