Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.sync side effect: Edits to checkbox in InputForm are immediately passed to TransactionList #22

Open
Felicious opened this issue Mar 12, 2021 · 1 comment
Open

.sync side effect: Edits to checkbox in InputForm are immediately passed to TransactionList #22

Felicious opened this issue Mar 12, 2021 · 1 comment
Labels
bug Something isn't working p3 gives code more structure

Comments

@Felicious
Copy link
Owner

Currently, any edits when editing a transaction in InputForm are immediately passed to the grandparent component, TransactionList. This should only happen when the form is submitted, so idk how this is happening.
Felicious added a commit that referenced this issue Mar 12, 2021
@Felicious
Reproduce problems in #22
3682d02
@Felicious
Copy link
Owner Author

299b13d

it is discovered the issue lies with the checkboxes themselves. Perhaps it's the .sync modifier in InputForm? perhaps sync passes all of the changes heard by the listeners up to not just the parents, but up the entire ancestry.

@Felicious Felicious changed the title Error: Edits to InputForm are immediately passed to TransactionList .sync side effect: Edits to checkbox in InputForm are immediately passed to TransactionList Mar 20, 2021
@Felicious Felicious added bug Something isn't working p3 gives code more structure labels Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p3 gives code more structure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Felicious