Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically get SUSHI version #165

Open
mint-thompson opened this issue Jun 26, 2024 · 0 comments
Open

Programmatically get SUSHI version #165

mint-thompson opened this issue Jun 26, 2024 · 0 comments

Comments

@mint-thompson
Copy link
Collaborator

Transferred from internal JIRA issue originally created 2020-12-15.

Right now, we hardcode the SUSHI version that FSH Online is using. We may be able to use pre- or post- build steps to do this. From Chris when discussing this originally on the pull request:

The SUSHI version is known at build-time. I think we could find a way to inject it into the code during the build - so it's not hard-coded in our source, but looks hard-coded in the output. I'm thinking we could do that as a post-build script that does a replacement in the output file or maybe use custom environment variables--maybe setting the SUSHI number programmatically as an env variable in a pre-build step... Anyway, I'm not sure the most elegant approach, and I don't think it has to be figured out in this PR, but I suspect we can come up with something.

BTW, I think we could pull the SUSHI version from the package-lock.json (but again, this would need to be handled during build rather than during runtime).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant