Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add match count to user prompt in DB commands #653

Open
bouthilx opened this issue Sep 7, 2021 · 0 comments · May be fixed by #656
Open

Add match count to user prompt in DB commands #653

bouthilx opened this issue Sep 7, 2021 · 0 comments · May be fixed by #656
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Milestone

Comments

@bouthilx
Copy link
Member

bouthilx commented Sep 7, 2021

We running orion db rm/set, there is a prompt for the user to confirm the operation, but there is no information about what will be executed (how many trials or exp will be affected?). These stats are printed after the operation but not before (in the prompt). The prompt messages (like here https://github.com/Epistimio/orion/blob/develop/src/orion/core/cli/db/rm.py#L34) should include this information. A function process_trial_count should be implemented like process_trial_rm to count the matching trials/exp before the operation is executed.

@mgermain

@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Sep 7, 2021
@bouthilx bouthilx added this to the v0.1.17 milestone Sep 7, 2021
@mgermain mgermain linked a pull request Sep 7, 2021 that will close this issue
@bouthilx bouthilx modified the milestones: v0.1.17, v0.2.1 Sep 10, 2021
@bouthilx bouthilx modified the milestones: v0.2.1, v0.2.2 Dec 21, 2021
@bouthilx bouthilx modified the milestones: v0.2.2, v0.2.3 Feb 13, 2022
@bouthilx bouthilx modified the milestones: v0.2.3, v0.2.5 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant