Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Henry's law data in seq_drydep_mod.F90 with input data #8

Open
fvitt opened this issue Sep 2, 2021 · 3 comments
Open

Replace Henry's law data in seq_drydep_mod.F90 with input data #8

fvitt opened this issue Sep 2, 2021 · 3 comments

Comments

@fvitt
Copy link
Contributor

fvitt commented Sep 2, 2021

Move hard-wired data (effective Henry's law coeffs, molecule names and weights, etc.) in drydep_mod to an input file. This will allow more flexibility.
@mvertens
Copy link
Contributor

mvertens commented Sep 2, 2021

@fvitt - can we move to rename seq_drydep_mod to shr_drydep_mod. I think that will be more consistent with the other names and remove confusion as to the mct implemention versus the nuopc implementation.

@fvitt
Copy link
Contributor Author

fvitt commented Sep 2, 2021

@fvitt - can we move to rename seq_drydep_mod to shr_drydep_mod. I think that will be more consistent with the other names and remove confusion as to the mct implemention versus the nuopc implementation.

Yes. Makes sense.

@billsacks
Copy link
Member

can we move to rename seq_drydep_mod to shr_drydep_mod

This makes sense to me, too. However, note that it will require coordination between components. I'd suggest doing it in multiple steps to have a period of backwards compatibility:

  1. Rename seq_drydep_mod to shr_drydep_mod, but keep a temporary seq_drydep_mod in place that merely publishes the names from shr_drydep_mod (i.e., it has some use statements of seq_drydep_mod and has public visibility, so that a component's use seq_drydep_mod, only : foo is equivalent to use shr_drydep_mod, only : foo). (If I'm not being clear I can illustrate it more explicitly. It should be easy.)
  2. Ask components to change their uses of seq_drydep_mod to shr_drydep_mod
  3. Once all components have done (2), seq_drydep_mod can be removed

This was referenced Jun 1, 2022
Merged
Merged
jedwards4b added a commit to ESCOMP/CMEPS that referenced this issue Jul 26, 2022
@jedwards4b
Merge pull request #303 from fvitt/dep_data_file
5e8d703 
Description of changes

This moves the hard-wired data from seq_drydep_mod to an input file that can be easily replaced to provide flexibility.
Specific notes

This PR needs to be coordinated with
ESCOMP/CAM#602

See relevant discussion in:
ESCOMP/CESM_share#8

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):
ESCOMP/CESM_share#8

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
bfb

Any User Interface Changes (namelist or namelist defaults changes)?
Added dep_data_file (in drv_flds_in) for the path of the input data file containing Henrys Law coefficients
Testing performed

Testing performed if application target is CESM:

(recommended) CIME_DRIVER=nuopc scripts_regression_tests.py

    machines: cheyenne, izumi
    details (e.g. failed tests):

(recommended) CESM testlist_drv.xml

    machines and compilers:
    details (e.g. failed tests):

(optional) CESM prealpha test

    machines and compilers
    details (e.g. failed tests):

    aux_cam tests
        machines and compilers: cheyenne-intel, izumi-gnu, izumi-nag
        details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

    (recommended) UFS-coupled testing
        description:
        details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

    (recommended) UFS-HAFS testing
        description:
        details (e.g. failed tests):

Hashes used for testing:

CESM:

    repository to check out: ESCOMP/CESM.git
    branch/hash:

UFS-coupled, then umbrella repostiory to check out and associated hash:

    repository to check out:
    branch/hash:

UFS-HAFS, then umbrella repostiory to check out and associated hash:

    repository to check out:
    branch/hash:
jedwards4b added a commit to ESCOMP/CESM_CPL7andDataComps that referenced this issue Jul 26, 2022
@jedwards4b
Merge pull request #15 from fvitt/dep_data_file
c930db9 
Read Henrys Law coefficients from file


This moves the hard-wired data from seq_drydep_mod to an input file that can be easily replaced to provide flexibility.

This PR needs to be coordinated with
ESCOMP/CAM#602

See relevant discussion in:
ESCOMP/CESM_share#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@billsacks @mvertens @fvitt