Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use %%BALENA_ARCH%% to inform --platform in FROM directive in Dockerfiles as they are incorrect, according to DockerHub #24

Open
MatthewCroughan opened this issue Feb 5, 2020 · 1 comment

Comments

@MatthewCroughan
Copy link
Contributor

MatthewCroughan commented Feb 5, 2020

Simply put, the docker hub wants armv7 but the variable %%BALENA_ARCH%% returns armv7hf. Without specifying a build arg via the Balena CLI, this isn't possible to change. This is useless considering the templating language already kind of implements what we would be doing with the balena cli, allowing us to make Dockerfile.raspberrypi3 and being able to specify --platform=linux/armv7 in it.

This issue relates to #6 #21 and balena-io/balena-cli#1508 heavily, as a resolution of 1508 would remove this problem, or supporting Docker Buildkit.

@MatthewCroughan MatthewCroughan changed the title Can't use %%BALENA_ARCH%% to inform --platform in FROM directive in Dockerfiles Can't use %%BALENA_ARCH%% to inform --platform in FROM directive in Dockerfiles as they are incorrect, according to DockerHub Feb 5, 2020
@MatthewCroughan
Copy link
Contributor Author

The .template will benefit from the use of these variables, though this limits us as we can no longer support arm devices via this template, only things that by chance happen to match up with the docker hub, such as amd64 or arm64. Raspberry Pi's are unaffected so long as we use their template extension, e.g .raspberrypi3, so this isn't too concerning. Though it is a bit annoying that Balena still does not support this basic feature.

This can be closed once balena-io/balena-cli#1408 is closed and we removed all --platform commands from the project, as they should not be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant