Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light simulation issue 2: Digitizing #197

Open
YifanC opened this issue Feb 6, 2024 · 0 comments
Open

Light simulation issue 2: Digitizing #197

YifanC opened this issue Feb 6, 2024 · 0 comments

Comments

@YifanC
Copy link
Collaborator

YifanC commented Feb 6, 2024

I think there is a problem in the light_sim.digitize_signal().
I think the sample_tick should be like this line, instead of this, because "signal" is already padded.
Based on the interpolation, it would shift the signal ~100 ticks (16ns). However, I also didn't see this shift...See the examples running the second event of MiniRun5_1E19_RHC.convert2h5.00666.EDEPSIM.hdf5.

_digi: sample_tick = isample * light.LIGHT_DIGIT_SAMPLE_SPACING / light.LIGHT_TICK_SIZE
_no_digi: sample_tick = isample * light.LIGHT_DIGIT_SAMPLE_SPACING / light.LIGHT_TICK_SIZE - light.LIGHT_TRIG_WINDOW[0] / light.LIGHT_TICK_SIZE + trigger_idx[itrig]
signal_ch159_MR5_666_digi
signal_ch159_MR5_666_no_digi

Need help here please: @mjkramer @krwood @liviocali @AWh1t3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant