Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events with no reco info do not have their truth info stored #58

Open
chenel opened this issue Feb 12, 2024 · 0 comments
Open

Events with no reco info do not have their truth info stored #58

chenel opened this issue Feb 12, 2024 · 0 comments

Comments

@chenel
Copy link
Collaborator

chenel commented Feb 12, 2024

The current architecture only fills truth info if a reco branch filler requests it. That means that events that happen to form no reconstructed objects in any of the detectors that are enabled (think, e.g.: lots of neutrons produced outside fiducial volume that make small blips inside it) won't have their truth info stored.

Fixing this would require the various RecoBranchFillers to invoke the TruthMatcher even when they don't have a reconstructed object. That's easy enough; but there's no way of enforcing that they do that, which means that events could easily slip through.

Should the trigger grouping machinery also group all the relevant true interactions as well? Should we just add in explicit calls to TruthMatcher in the reco branch fillers in an ad hoc way? More thought is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant