Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated validation of TPG algorithms #145

Open
adam-abed-abud opened this issue Oct 27, 2023 · 2 comments
Open

Automated validation of TPG algorithms #145

adam-abed-abud opened this issue Oct 27, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@adam-abed-abud
Copy link
Contributor

adam-abed-abud commented Oct 27, 2023

In the framework of adding tools to validate the TPG it would be nice to have an automated check. Such tool would be helpful for different tests, such as:

  1. validate naive and avx implementation of TPG algorithms
  2. provide a way to check that the current AVX implementations of the TPG algorithms provide sensible results against known patterns. Some checks include: time-over-threshold results, identifying channels with values above threshold, etc.
  3. Potentially, the validation step should also become an integration test.

Some instructions on how to run such tests would be beneficial

@adam-abed-abud
Copy link
Contributor Author

As discussed with Ivana, the next steps include making an application that given different known frame patterns it executes the TPG (naive or avx) for a specific amount of time and identifies key parameters such as the total number of hits, channels for the identified hits, etc.
Prepare the frame files to be added in asset list

@hristovaivana
Copy link
Contributor

As discussed in the last TPG technical meeting, I've added in the adc_peak_feature branch the instructions and the relevant app/scripts needed to generate WIBEth test patterns and to validate the TP hits found by the AVX and NAIVE implementation. The basic instructions are provided in the README file of fdreadoutlibs and I'm working on improving the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants