We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The constructor of appfwk::Application is designed for simplicity, i.e. it only accepts strings as arguments. This causes behind the scene multiple creations of the a ConfigurationManager: https://github.com/DUNE-DAQ/appfwk/blob/319a1da935d974efd6f11abefd5844e8114e2f9f/src/Application.cpp#L29C1-L40C2 which is not very elegant.
appfwk::Application
ConfigurationManager
If we are happy to change the signature of the constructor, this can be simplified very much to
Application( std::shared_ptr<ConfigurationManager>, std::string cmdlibimpl ) ;
or even
Application( std::shared_ptr<ConfigurationManager>, std::shared_ptr<cmdlib::CommandFacility> );
which contains all the necessary information.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The constructor of
appfwk::Applicationis designed for simplicity, i.e. it only accepts strings as arguments.This causes behind the scene multiple creations of the a
ConfigurationManager:https://github.com/DUNE-DAQ/appfwk/blob/319a1da935d974efd6f11abefd5844e8114e2f9f/src/Application.cpp#L29C1-L40C2
which is not very elegant.
If we are happy to change the signature of the constructor, this can be simplified very much to
Application( std::shared_ptr<ConfigurationManager>, std::string cmdlibimpl ) ;or even
Application( std::shared_ptr<ConfigurationManager>, std::shared_ptr<cmdlib::CommandFacility> );which contains all the necessary information.
The text was updated successfully, but these errors were encountered: