-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genereate_latlon_boundary does not work for an approach/limb image #8
Comments
I wonder if there is an existing algorithm for handling this type of stuff. |
If I remember correctly, the image where this was discovered did return a polygon even though none of the image edge pixels intersected the target. This should be looked at. |
@scsides This is probably due to how imageToGround behaves in USGSCSM when it doesn't intersect the body. It will return the point on the image ray closest to the body. |
It would be nice to find an existing library for this, but the algorithm in ISIS does produce a valid polygon for most cases including full image, full disk, limb, north pole, south pole, longitude boundary, but not both north and south poles in the same image. |
That's concerning. Is there anything that tells us it failed, but returned an invalid result anyway? |
@jessemapel says there should be a warning added if this occurs, and that we should check to make sure this is happening. |
generate_latlon_boundary doesn't seem to work for an approach/limb image, as it appears to only project points on the boundary of the image. If these pixels don't have the target in them, I'm not sure that the result will make sense.
The text was updated successfully, but these errors were encountered: