[Refactor] 명세서랑 다른 점 수정 및 로직 변경 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
명세서와 다른 부분이 있어서 수정했습니다.
개발하면서 어떤 점이 궁금했는지
가격 관련된 부분을 따로 공통부분으로 모아야할지 고민이긴합니다.
📸 결과물 스크린샷
[ticket]
{ "code": 200, "message": "티켓 선택 페이지 조회 성공", "data": { "airResultDto": { "dateDto": { "startDate": "2023-11-23 목", "endDate": "2023-11-30 목" }, "airId": 10, "airName": "진에어", "startTime": { "startTime": "08:35", "endTime": "11:15", "during": "2시간 40분" }, "endTime": { "startTime": "18:35", "endTime": "11:15", "during": "2시간 40분" } }, "ticketListDto": [ { "ticketId": 1, "companyName": "인터파크", "stars": 4, "card": "KEB 하나카드", "price": "467,100", "comment": 47819 }, { "ticketId": 2, "companyName": "트리플", "stars": 4, "card": "KEB 하나카드", "price": "467,900", "comment": 47819 }, { "ticketId": 3, "companyName": "마이리얼트립", "stars": 5, "card": "KEB 하나카드", "price": "467,900", "comment": 47819 }, { "ticketId": 4, "companyName": "노랑풍선", "stars": 3, "card": "KEB 하나카드", "price": "467,900", "comment": 47819 }, { "ticketId": 5, "companyName": "트립닷컴", "stars": 4, "card": "KEB 하나카드", "price": "467,900", "comment": 47819 }, { "ticketId": 6, "companyName": "참좋은여행", "stars": 3, "card": "KEB 하나카드", "price": "467,900", "comment": 47819 }, { "ticketId": 7, "companyName": "내일여행", "stars": 2, "card": "KEB 하나카드", "price": "467,900", "comment": 47819 } ] } }[main]
{ "cityName": "일본", "country": "삿포로", "startDate": "2023-11-23 목", "endDate": "2023-11-30 목", "companyAir": "대한항공", "minPriceString": "467,100원 출발" }🛠️ 테스트
🚀 API Endpoint