Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading polyscope version 1.2.0→2.3.0 #1743

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrading polyscope version 1.2.0→2.3.0 #1743

wants to merge 2 commits into from

Conversation

dcoeurjo
Copy link
Member

PR Description

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@dcoeurjo
Copy link
Member Author

@JacquesOlivierLachaud there is an issue with tangent_explorer due to a deprecated API use. Could you please have a look?

I don't know if this is related to this PR but dgtalCalcuus-halfsphere only returns a zero value map.

@JacquesOlivierLachaud
Copy link
Member

Apparently, polyscope SurfaceMesh does not expose any more faces and edges (when I look at surface_mesh.h). So the only way to correct the code is to memorise the vector of faces of the primal surface at construction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Geometry Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @JacquesOlivierLachaud