Fix seg fault and enable parameter error=0 in FrechetShortcut

[isivigno]

PR Description

Fix seg fault due to recent compilers in FrechetShortcut (Bertrand Kerautret, Isabelle Sivignon)
Fix FrechetShortcut to enable the parameter error to be equal to 0 and add new tests in testFrechetShortcut (Isabelle Sivignon)

Checklist

• Unit-test of your feature with Catch.
• Doxygen documentation of the code completed (classes, methods, types, members...)
• Documentation module page added or updated.
• New entry in the ChangeLog.md added.
• No warning raised in Debug mode.
• All continuous integration tests pass (Github Actions)

[dcoeurjo]

Thanks for the PR, I just have minor comments. best

[dcoeurjo]

Hi @isivigno, we are preparing the 1.4 release of DGtal. Could you please have a look to my comments on your PR?
thanks

[dcoeurjo]

few minor errors in the CI bots. could you please have a look @kerautret ?
(I would like to include this PR in the release)

[kerautret]

few minor errors in the CI bots. could you please have a look @kerautret ? (I would like to include this PR in the release)

Yes I am adding the PRECISION in the constructor (but also used in static)

[kerautret]

few minor errors in the CI bots. could you please have a look @kerautret ? (I would like to include this PR in the release)

Yes I am adding the PRECISION in the constructor (but also used in static)

not very nice since it also appears in the cone class, so we should add it in 3 constructors more ..

[kerautret]

@dcoeurjo for the CI I added a PR on the @isivigno branches isivigno#2

[dcoeurjo]

I was able to merge he PR on @isivigno repo but the PR was against the master, not the freshet branch. Let me check

[kerautret]

for the precision constant I can finish the stashed starting inclusion on classes if you think it better

[dcoeurjo]

let see if this one passes all tests.

[kerautret]

I was able to merge he PR on @isivigno repo but the PR was against the master, not the freshet branch. Let me check

oupst sure ;)

[dcoeurjo]

Ok I will merge this one and freeze the repo for the release

[dcoeurjo]

If you have anything you would like to change on this class, let's do that in the 1.5beta.

thanks