-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix seg fault and enable parameter error=0 in FrechetShortcut #1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I just have minor comments. best
Hi @isivigno, we are preparing the 1.4 release of DGtal. Could you please have a look to my comments on your PR? |
few minor errors in the CI bots. could you please have a look @kerautret ? |
Yes I am adding the PRECISION in the constructor (but also used in static) |
not very nice since it also appears in the cone class, so we should add it in 3 constructors more .. |
@dcoeurjo for the CI I added a PR on the @isivigno branches isivigno#2 |
Fix ci frechet fix
I was able to merge he PR on @isivigno repo but the PR was against the master, not the freshet branch. Let me check |
for the precision constant I can finish the stashed starting inclusion on classes if you think it better |
let see if this one passes all tests. |
oupst sure ;) |
Ok I will merge this one and freeze the repo for the release |
If you have anything you would like to change on this class, let's do that in the 1.5beta. thanks |
PR Description
Fix seg fault due to recent compilers in FrechetShortcut (Bertrand Kerautret, Isabelle Sivignon)
Fix FrechetShortcut to enable the parameter error to be equal to 0 and add new tests in testFrechetShortcut (Isabelle Sivignon)
Checklist