Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page to list users with a given badge #4318

Open
aapeliv opened this issue May 15, 2024 · 2 comments · May be fixed by #4389
Open

Page to list users with a given badge #4318

aapeliv opened this issue May 15, 2024 · 2 comments · May be fixed by #4389
Assignees
Labels
0.kind feature request A *requested* feature 1.topic backend This issue relates to the python backend 1.topic frontend

Comments

@aapeliv
Copy link
Member

aapeliv commented May 15, 2024

This would be cute!

@aapeliv aapeliv added 2.has feature (new) Implementation of a feature 1.topic backend This issue relates to the python backend 1.topic frontend labels May 15, 2024
@aapeliv aapeliv changed the title Padge to list users with a given badge Page to list users with a given badge May 15, 2024
@schradert schradert self-assigned this May 19, 2024
@schradert schradert added 0.kind feature request A *requested* feature and removed 2.has feature (new) Implementation of a feature priority: low labels May 22, 2024
@schradert schradert added this to the V1 milestone May 22, 2024
@schradert
Copy link
Contributor

schradert commented May 24, 2024

Lots of relevant code in #4246 and #4247

@schradert schradert linked a pull request May 28, 2024 that will close this issue
19 tasks
@schradert schradert linked a pull request May 28, 2024 that will close this issue
19 tasks
@aapeliv aapeliv modified the milestones: Safety & Moderation, Safety Jun 4, 2024
@schradert
Copy link
Contributor

schradert commented Jul 23, 2024

@bakeiro Maybe there is something wrong with the way I'm using react-query but the useBadges hook seems to not run in the BadgesPage component when I first load the page /badges. In ReactQueryDevTools, I can run Refetch on the "badges" query, which does return the correct data. Why do you think it isn't running on page load? You should be able to reproduce this by:

cd app
docker run --pull always --rm -w /app -v $(pwd):/app registry.gitlab.com/couchers/grpc ./generate_protos.sh
docker-compose up --build &
cd web
yarn start:localdev

(FYI I made a separate script to actually use the docker database, which isn't used by yarn start)

EDIT: Sorry I'm an idiot. I'm not sure why is it was able to work before, but I just had to check whether the value existed yet by changing Object.values(badges) to badges && Object.values(badges) ... Not sure why this escaped me earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind feature request A *requested* feature 1.topic backend This issue relates to the python backend 1.topic frontend
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants