Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Prestige Max Calculation #1178

Open
MSbitani opened this issue Mar 6, 2024 · 0 comments
Open

Possible Prestige Max Calculation #1178

MSbitani opened this issue Mar 6, 2024 · 0 comments
Labels

Comments

@MSbitani
Copy link

MSbitani commented Mar 6, 2024

Bug description

The calculation for the max possible prestige is incorrect, specifically regarding wrinklers. After popping the wrinklers with Skruuia in the Diamond slot, the max drops dramatically. This might be related to #248.

I think I've determined the problem to be that the CacheWrinklersTotal is being double counted in the calculation. It is added to CacheRealCookiesEarned:

let choEggTotal = Game.cookies + CacheSellForChoEgg;
if (Game.cpsSucked > 0) choEggTotal += CacheWrinklersTotal;
CacheRealCookiesEarned = Math.max(Game.cookiesEarned, choEggTotal);
and then again directly to the prestige calculation:
const possiblePresMax = Math.floor(
Game.HowMuchPrestige(
CacheRealCookiesEarned +
Game.cookiesReset +
CacheWrinklersTotal +
(Game.HasUnlocked('Chocolate egg') && !Game.Has('Chocolate egg') ? CacheLastChoEgg : 0),
),
);

Which explains why popping the wrinklers drops the max prestige by the amount that was popped.

I'm also not sure if the Dragon Guts aura is ever included in the wrinkler calculations, but that doesn't have a direct effect on this issue.

To reproduce

  1. Note max possible prestige stat
  2. Pop all wrinklers
  3. See max possible prestige stat drop significantly

Screenshot

Before popping:
Screenshot 2024-03-06 11 25 10 AM

After popping with Skruuia:
image

Save file

Mi4wNTJ8fDE3MDk1MzAwOTAwNTE7MTcwNzg4NjQ5MDQyMzsxNzA5NzA5MzgxMDIzO01jQ29tcHV0ZXI7ZW5tZWY7MCwxLDAsMCwwLDAsMHwwMTExMDAwMDEwMDAwMDEwMDEwMDAxMTAwMDF8MS45Nzk4NjI1OTg1ODQ4NzE4ZSs1NzsyLjgwMDI1MjI3Njc5ODIxNDZlKzU3OzUyMzg7MTU4NTs5LjI1MjM1NzM1MzMzMTQ1OGUrNTY7Mzk0MDs0OzA7MS4wMjAyMzkwMDIzNDg1Njk2ZSs1NzszOzQ7MDswOy0xOzEwOzEzMzszLjkxNTY1NDM0OTgyNDkwMDdlKzU2OzI4OzE0Ozk3Oy0xOzU7OzQuMzgyMTU1NzkyNDY3MjY0NWUrNTc7MTI7MTAwNjcwMTMyNjAzMTczMzsxNjgyMTQyMjM2NTU2OTM7ODM4NDg3MTAyMzc2MDQwOzA7MDs1Mzs1Mjs2NDE7MjI1OzQ3OTsyNzsxNTsxOzE7NzU7MDswOzE7Mjc7MTcwOTY0NDAyMTAzNTswOzA7MjI3OzQxOzE7MTsyLjUyMjAwNDM1NjkxMDIyNTdlKzUxOzUwOzE7MTt8OTEwLDEyNzAsNi43NDY2NDg0MjcwNDQzMTJlKzU2LDEsLDAsOTEwOzg4MCwxMjQwLDEuNDY1MDg2MDczODU2NjgxZSs1NSwwLCwxLDg4MDs4NTAsMTIwMCwxLjk1NTg5NTk1Nzg2ODAxNDJlKzU0LDYsMTcwOTYxMzc4MTAxNDoyOjE3MDk1Mzg0Mzc0NTI6MToyOjExOjE6MDoxNzA5NTMwMDkwMDY0OiAxMTExMTAwMDAwMDAwMTAwMDAwMDAwMDAwMDAwMDAwMDAwIDA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOjA6MDowOiwwLDg1MDs4MzAsMTE4MCw1LjkyNDQ2ODk4ODAwNTI3OWUrNTQsMCwsMSw4MzA7ODEwLDExNjAsNC44NzkzNjM4NTM3MzkzMzNlKzUzLDAsLDEsODEwOzc5MCwxMTQwLDcuMTQ1MDIyOTQzMjAxMTM1ZSs1MiwxLDA6MDoxOjYwNjUzNS43MjkxNDc2NDE5OjE6IDMyODY6MTotMTI6MjY0OjA6MDowOjEwMCE3ODM2OjE6ODE6NjY4OjA6MDowOjAhOTQ1ODoyOi0zNTo2NjI6MDowOjA6MTAwITg0Nzc6NDo2NTo1OTQ6MDowOjA6MCExMTA5MTowOi0xODozMjM6MDowOjA6MTAwITk2Njc6MTotMTQ6NDA2OjA6MDowOjEwMCE5OTU0OjU6MTU6NjEyOjA6MDowOjAhMTA0MjU6MDotMTU6MTczOjA6MDowOjEwMCExMDAwMjoxOjI4OjczOjA6MDowOjAhMTU4OTQ6NToxMjoyMzA6MDowOjA6MCE5OTQ5OjA6LTI2OjQ1NTowOjA6MDowITk5NTI6NTozMjo2Njk6MDowOjA6MTAwITExMTQzOjE6LTMwOjMzMTowOjA6MDowITE0OTA2OjI6LTc4OjI0NzowOjA6MDowITEyODU1OjA6LTE6MTE3OjA6MDowOjAhMTAwNTE6NTotNDc6MjMwOjA6MDowOjAhMTg0NDM6NTo1MTozMzk6MDowOjA6MCExNjU1NjoxOjE1OjMyOTowOjA6MDoxMDAhIDEsMCw3OTA7NzgwLDExMzAsNi4wNjkyMzg0NTExNjY5NjJlKzU0LDEsOS83LzMvOCAwIDE3MDk3MDkzNzMzODUgMSwwLDc4MDs3NjAsMTExMCw0LjcwODQ2MTk0ODM2ODUyOGUrNTIsMSwxMTYgMzIgMzY1IDEsMCw3NjA7NzQwLDEwOTAsOS4xNDY0Mzc5MDI4NTQwN2UrNTEsMCwsMSw3NDA7NzIwLDEwNzAsMy40MjkyNzE4NzM0MTQ2NDVlKzUyLDAsLDEsNzIwOzcwMCwxMDUwLDYuNzg4NTczMjkxNTc5OTU3ZSs1MiwwLCwxLDcwMDs2ODAsMTAzMCwzLjU1NjQzNDkyNDI4NTgwMDdlKzUzLDAsLDEsNjgwOzY2MCwxMDEwLDcuNDA3NDM5MDg4NTYxODE0ZSs1MiwwLCwxLDY2MDs2NTAsMTAwMCw0LjE1MTkwODYzMTMyNzE0NmUrNTMsMCwsMSw2NTA7NjMwLDk4MCw4Ljk3MjkwODY2MjQ4MDIzOGUrNTMsMCwsMSw2MzA7NjEwLDk2MCw1Ljg0ODU2NDgxMDUyNjgyNzVlKzU0LDAsLDEsNjEwOzU3MCw5MjAsMi45NjcxOTA4MzYyNDY4MTE2ZSs1NSwwLCwxLDU3MDs1MzAsODgwLDQuMjQzMjQ4Njk2MzgxOTRlKzU0LDAsLDEsNTMwOzUwMCw4NTAsMS44MjA0MzkyODE4NzY5MDQ2ZSs1NSwwLCwxLDUwMDs0NzAsODI3LDEuMDU4NTE1NTY0NzIxNTI1OGUrNTYsMCwsMSw0NzA7fDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDExMTExMTExMDAxMTExMTEwMDEwMDAxMTAwMTExMTExMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDEwMTAxMDAwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDAxMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDAwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDExMTExMTExMTExMTAwMTExMTExMTExMTExMTExMTExMTEwMDAwMDAwMDAwMDAwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMDAwMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMDAxMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMDAwMDAwMDAwMDAwMDAwMDAwMTExMTExMTExMTExMTExMTExMTEwMDAwMDAwMDExMTEwMDExMTExMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAxMTExMDAwMDAwMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMDAwMDExMTExMTExMTExMTExMTExMTExMTExMDEwMTAxMDAwMDAwMDAwMTExMTExMDAwMDAwMTExMTAwMDAwMDAwMDAwMDExMTF8MTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMDEwMTExMTAxMTExMTEwMTEwMDAwMDExMTExMTAwMTExMTExMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDExMTExMTExMTEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMDAxMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMDAwMDAwMDAwMDAwMTEwMDExMTExMTExMTExMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMDAwMDAxMTExMTExMTExMTEwMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMDExMTExMTExMTEwMDAxMDAwMTAxMTExMTAxMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTAxMTExMTExMTExMTAwMTExMDExMTEwMTExMDAwMDExMTExMTExMTExMTAwMTExMDExMTExMTExMTExMTEwMDAwMDEwMTEwMDExMTEwMDAwMTEwMDAwMTEwMDEwMTExMTExMTExMTAwMDAxMTEwMTExMTExMTExMTAwMDAwMDAwMDAwMTExMHx8Q29va2llTW9uc3Rlcjp7InNldHRpbmdzIjp7IkNQU01vZGUiOjEsIkF2Z0NQU0hpc3QiOjAsIkF2Z0NsaWNrc0hpc3QiOjAsIkNhbGNXcmluayI6MCwiU2NhbGUiOjIsIlNjYWxlRGVjaW1hbHMiOjIsIlNjYWxlU2VwYXJhdG9yIjowLCJTY2FsZUN1dG9mZiI6OTk5OTk5LCJUaW1lRm9ybWF0IjowLCJEZXRhaWxlZFRpbWUiOjEsIlBQRGlzcGxheVRpbWUiOjAsIkJ1aWxkQ29sb3VyIjoxLCJQUE9ubHlDb25zaWRlckJ1eWFibGUiOjAsIlBQRXhjbHVkZVRvcCI6MCwiUFBSaWdpZGVsTW9kZSI6MSwiUFBTZWNvbmRzTG93ZXJMaW1pdCI6IjAiLCJDb2xvdXJCbHVlIjoiIzRiYjhmMCIsIkNvbG91ckdyZWVuIjoiIzAwZmYwMCIsIkNvbG91clllbGxvdyI6IiNmZmZmMDAiLCJDb2xvdXJPcmFuZ2UiOiIjZmY3ZjAwIiwiQ29sb3VyUmVkIjoiI2ZmMDAwMCIsIkNvbG91clB1cnBsZSI6IiNmZjAwZmYiLCJDb2xvdXJHcmF5IjoiI2IzYjNiMyIsIkNvbG91clBpbmsiOiIjZmYxNDkzIiwiQ29sb3VyQnJvd24iOiIjOGI0NTEzIiwiQm90QmFyIjowLCJUaW1lckJhciI6MSwiVGltZXJCYXJQb3MiOjAsIlRpbWVyQmFyT3ZlcmxheSI6MiwiQXV0b3NhdmVUaW1lckJhciI6MSwiVXBCYXJDb2xvdXIiOjEsIlVwZ3JhZGVCYXJGaXhlZFBvcyI6MSwiU29ydEJ1aWxkaW5ncyI6MiwiU29ydFVwZ3JhZGVzIjoxLCJVcGdyYWRlc05ldmVyQ29sbGFwc2UiOjAsIkRyYWdvbkF1cmFJbmZvIjoxLCJHcmltb2lyZUJhciI6MSwiR0NUaW1lciI6MSwiRmF2aWNvbiI6MSwiV3JpbmtsZXJCdXR0b25zIjoxLCJIaWRlU2VjdGlvbnNCdXR0b25zIjowLCJUb29sdGlwQnVpbGRVcGdyYWRlIjoxLCJUb29sdGlwQW1vciI6MSwiVG9vbFdhcm5MdWNreSI6MSwiVG9vbFdhcm5MdWNreUZyZW56eSI6MSwiVG9vbFdhcm5Db25qdXJlIjoxLCJUb29sV2FybkNvbmp1cmVGcmVuenkiOjEsIlRvb2xXYXJuRWRpZmljZSI6MSwiVG9vbFdhcm5Vc2VyIjowLCJUb29sV2FybkJvbiI6MSwiVG9vbFdhcm5Qb3MiOjEsIlRvb2x0aXBHcmltIjoxLCJUb29sdGlwV3JpbmsiOjEsIlRvb2x0aXBMdW1wIjoxLCJUb29sdGlwUGxvdHMiOjEsIlRvb2x0aXBQYW50aGVvbiI6MSwiVG9vbHRpcEFzY2VuZEJ1dHRvbiI6MSwiU3RhdHMiOjEsIk1pc3NpbmdVcGdyYWRlcyI6MSwiTWlzc2luZ0FjaGlldmVtZW50cyI6MSwiVXBTdGF0cyI6MSwiSGVhdmVubHlDaGlwc1RhcmdldCI6MSwiU2hvd01pc3NlZEdDIjoxLCJUaXRsZSI6MSwiR2VuZXJhbFNvdW5kIjoxLCJHQ05vdGlmaWNhdGlvbiI6MSwiR0NGbGFzaCI6MSwiQ29sb3VyR0NGbGFzaCI6IiNmZmZmZmYiLCJHQ1NvdW5kIjowLCJHQ1ZvbHVtZSI6MTAwLCJHQ1NvdW5kVVJMIjoiaHR0cHM6Ly9mcmVlc291bmQub3JnL2RhdGEvcHJldmlld3MvNjYvNjY3MTdfOTMxNjU1LWxxLm1wMyIsIkZvcnR1bmVOb3RpZmljYXRpb24iOjEsIkZvcnR1bmVGbGFzaCI6MSwiQ29sb3VyRm9ydHVuZUZsYXNoIjoiI2ZmZmZmZiIsIkZvcnR1bmVTb3VuZCI6MSwiRm9ydHVuZVZvbHVtZSI6MTAwLCJGb3J0dW5lU291bmRVUkwiOiJodHRwczovL2ZyZWVzb3VuZC5vcmcvZGF0YS9wcmV2aWV3cy8xNzQvMTc0MDI3XzMyNDI0OTQtbHEubXAzIiwiU2VhTm90aWZpY2F0aW9uIjoxLCJTZWFGbGFzaCI6MSwiQ29sb3VyU2VhRmxhc2giOiIjZmZmZmZmIiwiU2VhU291bmQiOjEsIlNlYVZvbHVtZSI6MTAwLCJTZWFTb3VuZFVSTCI6Imh0dHBzOi8vd3d3LmZyZWVzb3VuZC5vcmcvZGF0YS9wcmV2aWV3cy8xMjEvMTIxMDk5XzIxOTMyNjYtbHEubXAzIiwiR2FyZEZsYXNoIjowLCJDb2xvdXJHYXJkRmxhc2giOiIjZmZmZmZmIiwiR2FyZFNvdW5kIjowLCJHYXJkVm9sdW1lIjoxMDAsIkdhcmRTb3VuZFVSTCI6Imh0dHBzOi8vZnJlZXNvdW5kLm9yZy9kYXRhL3ByZXZpZXdzLzEwMy8xMDMwNDZfODYxNzE0LWxxLm1wMyIsIk1hZ2ljTm90aWZpY2F0aW9uIjowLCJNYWdpY0ZsYXNoIjoxLCJDb2xvdXJNYWdpY0ZsYXNoIjoiI2ZmZmZmZiIsIk1hZ2ljU291bmQiOjEsIk1hZ2ljVm9sdW1lIjoxMDAsIk1hZ2ljU291bmRVUkwiOiJodHRwczovL2ZyZWVzb3VuZC5vcmcvZGF0YS9wcmV2aWV3cy8yMjEvMjIxNjgzXzEwMTUyNDAtbHEubXAzIiwiV3JpbmtsZXJOb3RpZmljYXRpb24iOjAsIldyaW5rbGVyRmxhc2giOjAsIkNvbG91cldyaW5rbGVyRmxhc2giOiIjZmZmZmZmIiwiV3JpbmtsZXJTb3VuZCI6MSwiV3JpbmtsZXJWb2x1bWUiOjEwMCwiV3JpbmtsZXJTb3VuZFVSTCI6Imh0dHBzOi8vZnJlZXNvdW5kLm9yZy9kYXRhL3ByZXZpZXdzLzEyNC8xMjQxODZfODA0My1scS5tcDMiLCJXcmlua2xlck1heE5vdGlmaWNhdGlvbiI6MCwiV3JpbmtsZXJNYXhGbGFzaCI6MSwiQ29sb3VyV3JpbmtsZXJNYXhGbGFzaCI6IiNmZmZmZmYiLCJXcmlua2xlck1heFNvdW5kIjoxLCJXcmlua2xlck1heFZvbHVtZSI6MTAwLCJXcmlua2xlck1heFNvdW5kVVJMIjoiaHR0cHM6Ly9mcmVlc291bmQub3JnL2RhdGEvcHJldmlld3MvMTUyLzE1Mjc0M18xNTY2My1scS5tcDMiLCJCdWxrQnV5QmxvY2siOjEsIkZhdm91cml0ZVNldHRpbmdzIjoxfSwiaGVhZGVycyI6eyJGYXZvdXJpdGUiOjEsIkNhbGN1bGF0aW9uIjoxLCJOb3RhdGlvbiI6MSwiQ29sb3VycyI6MSwiQmFyc0Rpc3BsYXkiOjEsIlRvb2x0aXAiOjEsIlN0YXRpc3RpY3MiOjEsIk5vdGlmaWNhdGlvbiI6MSwiTm90aWZpY2F0aW9uR2VuZXJhbCI6MSwiTm90aWZpY2F0aW9uR0MiOjEsIk5vdGlmaWNhdGlvbkZDIjoxLCJOb3RpZmljYXRpb25TZWEiOjEsIk5vdGlmaWNhdGlvbkdhcmQiOjEsIk5vdGlmaWNhdGlvbk1hZ2kiOjEsIk5vdGlmaWNhdGlvbldyaW5rIjoxLCJOb3RpZmljYXRpb25Xcmlua01heCI6MSwiTWlzY2VsbGFuZW91cyI6MSwiTHVja3kiOjEsIkNoYWluIjoxLCJTcGVsbHMiOjEsIkdhcmRlbiI6MSwiUHJlc3RpZ2UiOjEsIldyaW5rIjoxLCJTZWEiOjEsIkFjaGlldnMiOjEsIk1pc2MiOjEsImluZm9NZW51IjoxLCJvcHRpb25zTWVudSI6MX0sImZhdm91cml0ZVNldHRpbmdzIjpbXSwidmVyc2lvbiI6IjIuMDUyLjEwIiwibG9ja2VkTWluaWdhbWVzIjpbIjIiLCI1Il19O2Nvb2tpZU1vbnN0ZXJGcmFtZXdvcms6eyJzZXR0aW5ncyI6e30sImhlYWRlcnMiOnsiaW5mb01lbnUiOjEsIm9wdGlvbnNNZW51IjoxfSwiZmF2b3VyaXRlU2V0dGluZ3MiOltdfTs%3D%21END%21

Browser / Steam / Version

Chrome, v. 2.052

@MSbitani MSbitani added the Bug label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant