Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighting/AO adaptations to prevent visual artefacts #114

Open
Anton-Le opened this issue Oct 12, 2020 · 7 comments
Open

Lighting/AO adaptations to prevent visual artefacts #114

Anton-Le opened this issue Oct 12, 2020 · 7 comments

Comments

@Anton-Le
Copy link
Contributor

GPUdomains
As can be seen in the above picture (indicated by the arrows) at the beginning of the simulation the structure of the GPU grid appears to be visible. This happens for particles as well as densities. As the simulation progresses the effects fade, but this takes some time and the structure suggests that there is something happening at the boundaries of the sub-domains, which does not correspond to reality.

@PrometheusPi
Copy link
Member

PrometheusPi commented Oct 12, 2020

I think if you zoom in the spheres' surfaces are clipped at the super-cell boundaries. (see noisy structure, up arrow)
Additionally AO has known GPU/MPI boundary issues (left arrow).
The first should be fixed, the latter only occurs with AO:

@PrometheusPi
Copy link
Member

@Anton-Le Could you also provide a zoomed in picture (from your last simulation).

@Anton-Le
Copy link
Contributor Author

20089_annotated
Here's a version later on in the simulation. It may be a tad difficult to see in the static picture, but in the animation it is apparent that there are dim joints at the indicated locations.
Particle size set to 0.3

@PrometheusPi
Copy link
Member

@Anton-Le Thanks do you have a extremely zoomed in image where the clipping of the sphere is visible?

@PrometheusPi
Copy link
Member

4281

@PrometheusPi
Copy link
Member

In more detail, the lines are next to clipped particles and most likely align with super cells borders (not GPU boarders).
4281

@Anton-Le
Copy link
Contributor Author

Anton-Le commented Oct 14, 2020

Here's a brightened version with reduced contrast from the beginning of the simulation.
Visualized is the current density. Note the distinct lines in the domain which appear to correspond to the boundaries between GPUs
15739_brightened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants