Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"mini design system" link in components-2 workshop goes somewhere weird and broken #1063

Open
illicitonion opened this issue Oct 10, 2024 · 1 comment
Assignees

Comments

@illicitonion
Copy link
Member

Go to https://github.com/CodeYourFuture/CYF-Workshops/blob/main/components-2/readme.md

Click the link with text "mini design system"

Find yourself on https://cyf-workshop.netlify.app/components-2/ which doesn't seem to render right. Some examples:

These should presumably be checkboxes?
Screenshot 2024-10-10 at 18 11 40

These LOs are janky:
Screenshot 2024-10-10 at 18 11 56

This mermaid isn't rendered:
Screenshot 2024-10-10 at 18 12 06

The in-page-rendered version on https://programming.codeyourfuture.io/structuring-data/sprints/3/day-plan/ looks fine, so I'm not sure what's going on here...

@SallyMcGrath
Copy link
Member

It's just an old workshop, I think, that predates this curriculum. I can bang in a common module instead of whatever I'm using here to render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants